Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#8915: selector prevent edit selection on prolonged keydown #8960

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

Clem-Fern
Copy link
Contributor

Hey @Eugeny, I hpe you're great !

As discuss in #8915, pressing Backspace in selector without releasing the key immediately edit the selected item. It can be a bit unpractical. This PR aims to fix this problem by preventing item edition if backspace keyup event hasn't been fired before.

Feel free to aske if any changes needed :)

Fix #8915

@Eugeny Eugeny merged commit 27bf7c4 into Eugeny:master Sep 20, 2023
10 checks passed
@Eugeny
Copy link
Owner

Eugeny commented Sep 20, 2023

Thank you!

@Clem-Fern Clem-Fern deleted the fix#8915 branch September 20, 2023 22:13
@konstantin83
Copy link

I'm still not so good in github, unfotunately ( Can you please tell if this fix is already in release or in alpha? I mean, can I already somehow download a version that contains it?

@Clem-Fern
Copy link
Contributor Author

Clem-Fern commented Oct 5, 2023

Hey @konstantin83,

You can download the latest night build here (these builds contain the fix added in this PR).
https://nightly.link/Eugeny/tabby/workflows/build/master

@konstantin83
Copy link

@Clem-Fern thank you. I tried to download the latest 1.0.201, but there is no linux release in it.
So I downloaded 1.0.200, and the bug is still there.
Sorry for bothering you, but maybe I'm doing something wrong?

@Eugeny
Copy link
Owner

Eugeny commented Oct 7, 2023

@konstantin83 Linux binaries have failed to upload for the v201 release but I've added them manually now

@konstantin83
Copy link

Dear @Clem-Fern and @Eugeny thank you for you help! It's ok now!
Ans also I didn't even know what backspace was for in Select Profile popup. Now I know )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Funny but annoying Backspace issue in Profiles & connections
3 participants