Add support for arm platforms #5907

Jai-JAP · 2022-03-08T17:40:02Z

Add support for

Linux armv7l, arm64
Windows arm64

Closes #3947, #2694, #1492

Eugeny · 2022-03-08T18:19:05Z

Looking great, can't wait to test 👍

Jai-JAP · 2022-03-09T05:06:27Z

Quick Status update:
Got Linux armv7l, arm64 builds working

Issues-translate-bot · 2022-03-09T05:06:40Z

The translator bot has detected that this issue body's language is not English, and has translated it automatically.

Quick Status update:
Got Linux arm64 builds working

Jai-JAP · 2022-03-09T06:13:47Z

Quick Status update:
Got Windows arm64 builds working

Issues-translate-bot · 2022-03-09T06:14:07Z

The translator bot has detected that this issue body's language is not English, and has translated it automatically.

Quick Status update:
For Windows arm64 builds working

Jai-JAP · 2022-03-09T06:16:21Z

Here are the build artifacts
https://github.com/Jai-JAP/tabby/actions/runs/1955581847

GitHub
Update build-windows.js · Jai-JAP/tabby@725edd5
A terminal for a more modern age. Contribute to Jai-JAP/tabby development by creating an account on GitHub.

Jai-JAP · 2022-03-09T07:09:12Z

@Eugeny
running Linux armv7l or arm64 build gives the below log and hangs
any ideas ..?

innerError Error: Cannot find module '../build/Debug/pty.node'
Require stack:
- /opt/Tabby/resources/app.asar/node_modules/@tabby-gang/node-pty/lib/unixTerminal.js
- /opt/Tabby/resources/app.asar/node_modules/@tabby-gang/node-pty/lib/index.js
- /opt/Tabby/resources/app.asar/dist/main.js
- 
    at Module._resolveFilename (node:internal/modules/cjs/loader:940:15)
    at Function.n._resolveFilename (node:electron/js2c/browser_init:249:1105)
    at Module._load (node:internal/modules/cjs/loader:785:27)
    at Function.c._load (node:electron/js2c/asar_bundle:5:13331)
    at Module.require (node:internal/modules/cjs/loader:1012:19)
    at require (/opt/Tabby/resources/app.asar/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
    at Object.<anonymous> (/opt/Tabby/resources/app.asar/node_modules/@tabby-gang/node-pty/lib/unixTerminal.js:33:15)
    at Module._compile (/opt/Tabby/resources/app.asar/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1169:10)
    at Module.load (node:internal/modules/cjs/loader:988:32) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/opt/Tabby/resources/app.asar/node_modules/@tabby-gang/node-pty/lib/unixTerminal.js',
    '/opt/Tabby/resources/app.asar/node_modules/@tabby-gang/node-pty/lib/index.js',
    '/opt/Tabby/resources/app.asar/dist/main.js',
    undefined
  ]
}
[28747:0309/123501.087413:ERROR:nss_util.cc(286)] After loading Root Certs, loaded==false: NSS error code: -8018

Jai-JAP · 2022-03-09T07:10:48Z

Windows arm64 is untested

Eugeny · 2022-03-09T09:39:23Z

That means that Node couldn't load the app/node_modules/@tabby-gang/node-pty/build/Release/pty.node native module, likely because it didn't get compiled for the correct arch. You can get the exact error by creating a 1.js file in the repo root with the following content

require('./app/node_modules/@tabby-gang/node-pty/build/Release/pty.node')

and running it as yarn electron 1.js

P.S. the module is built by electron-rebuild via ./scripts/build-native.js

Jai-JAP · 2022-03-09T12:46:24Z

The output of yarn electron 1.js

yarn run v1.19.1
$ /home/runner/work/tabby/tabby/node_modules/.bin/electron 1.js
/home/runner/work/tabby/tabby/node_modules/electron/dist/electron exited with signal SIGTRAP
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Jai-JAP · 2022-03-25T11:32:24Z

Windows arm64 builds are confirmed working

Jai-JAP · 2022-03-25T11:37:51Z

Linux arm builds compiled by me on a RPi4 are located at https://github.com/jai-jap/tabby-arm-builds/releases
Confirmed working

Jai-JAP · 2022-03-25T14:23:20Z

Build artifacts for the latest commit can be found here

Windows arm64 portable is known working but the installer should also work as building arm64 is supported natively on Windows and Mac OS by electron

Jai-JAP · 2022-03-25T14:23:50Z

This is now ready to merge in my view
@Eugeny have a look

Eugeny · 2022-03-25T14:37:29Z

Fantastic 👍

Is the electron==17.0.0 downgrade still necessary on Linux?

theofficialgman · 2022-03-25T16:20:11Z

I don't see why the Jai-JAP says the electron downgrade is necessary.
When I look at the electron releases on the github https://github.com/electron/electron/releases/tag/v17.2.0, prebuilts for ia32 (x86), x64 (x86_64), armv7l, and arm64 linux are all there

GitHub
Release electron v17.2.0 · electron/electron
Release Notes for v17.2.0 Features
Added ses.setCodeCachePath() API for setting code cache directory. #33285 (Also in 18)

Fixes

Fire 'show' event when a BrowserWindow is shown via maximize(). #3...

Jai-JAP · 2022-03-26T06:22:32Z

Fantastic 👍

Is the electron==17.0.0 downgrade still necessary on Linux?

Yes since for electron >= 17.0.1 compiling v8 engine results in error same as in this comment

Eugeny · 2022-03-26T10:47:26Z

Got it - fantastic work!

allcontributors · 2022-03-26T10:47:27Z

@Eugeny

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

Eugeny · 2022-03-26T10:47:44Z

@allcontributors please add @Jai-JAP for platform

allcontributors · 2022-03-26T10:48:37Z

@Eugeny

I've put up a pull request to add @Jai-JAP! 🎉

Eugeny · 2022-04-05T07:48:29Z

@Jai-JAP the PR accidentally broke x86_64 Windows builds - I've fixed it in 95ae4b8 but could you please double-check that the arm64 build is still working after this?

Jai-JAP · 2022-04-05T16:14:36Z

I will check this later as i am busy with exams. Maybe it will take 1 or 2 days

Jai-JAP · 2022-04-06T11:00:02Z

@Jai-JAP the PR accidentally broke x86_64 Windows builds - I've fixed it in 95ae4b8 but could you please double-check that the arm64 build is still working after this?

No they don't as Windows arm64 build artifacts are the x64 builds with other name and not arm64 ones

Jai-JAP · 2022-04-06T11:32:45Z

tabby/scripts/build-native.js

Line 6 in 95ae4b8

    
           process.env.ARCH = process.env.ARCH ?? (process.arch === 'arm' ? 'armv7l' : process.arch)

the ?? in this line seems to be the issue. I think it should be ||
Also the brackets may be the issue too

Jai-JAP · 2022-04-06T12:02:34Z

Probably fixed in #6106

mirogl · 2022-04-21T08:19:21Z

Hi,
I tested release 1.0.176 Windows arm64 portable. Just unpacked it and created an empty data dir in the new directory.
When i start Tabby.exe from cmd i get 👍

C:\Users\miros\Downloads\tabby>
reset user data to C:\Users\miros\Downloads\tabby\data
[27940:0421/101508.583:ERROR:gpu_init.cc(446)] Passthrough is not supported, GL is disabled, ANGLE is

But i don't get any Window.

I habe a Surface Pro X with SQ2 Arm64 processor and Windows 11 Version 10.0.22000 Build 22000

Thanks
Miro

Jai-JAP · 2022-04-21T13:44:07Z

@mirogl Can you try adding --disable-gpu to i.e., args run the command Tabby.exe --disable-gpu

Also let's continue this in a new issue if this doesn't work

Jai-JAP · 2022-04-21T13:47:49Z

Also if it doesn't work delete all tabby folders in %APPDATA% and also in downloads and try again

Jai-JAP · 2022-04-21T13:53:42Z

@Eugeny this is not related to tabby and is likely an issue with electron/chromium itself. See electron/electron#32317

mirogl · 2022-04-21T14:53:44Z

Also if it doesn't work delete all tabby folders in %APPDATA% and also in downloads and try again

Hi,thanks - i deleted %APPDATTA%\tabby and the existing Folder under Downloads. After a Reboot i unpacked tabby-1.0.176-portable-arm64.zip and created a emoty data direcoty in the extracted dir.

Still hangs at:

C:\Users\miros\Downloads\tabby-1.0.176-portable-arm64>
reset user data to C:\Users\miros\Downloads\tabby-1.0.176-portable-arm64\data

Cheers
Miro

Jai-JAP · 2022-04-22T06:19:15Z

@mirogl can you open a new issue with all details

Jai-JAP and others added 10 commits March 8, 2022 20:59

Add Linux armv7l and arm64 support

a874a5e

Manual run

90bd8b4

Fixes

ea38943

Fix Linux pacman uploads

d8bec49

Add windows arm64

690a632

Update electron-builder.yml

c533e6c

Update build.yml

d35c03d

Update build.yml

e2d4ef5

Update build.yml

b70a193

Update build.yml

5c325a3

Jai-JAP marked this pull request as draft March 8, 2022 17:49

Update build-linux.js

b5506cf

Jai-JAP added 2 commits March 9, 2022 11:17

Update build.yml

1b31187

Update build-windows.js

725edd5

Jai-JAP marked this pull request as ready for review March 9, 2022 06:13

Jai-JAP added 3 commits March 9, 2022 11:52

Merge branch 'Eugeny:master' into master

8c96788

Update build-linux.js

c3e4031

Revert last change

b27f5c2

Jai-JAP marked this pull request as draft March 9, 2022 07:09

Update build.yml

38f8a7c

Jai-JAP added 2 commits March 25, 2022 16:25

Update build-native.js

ead2dbc

Update build-native.js

5a66a64

Jai-JAP marked this pull request as ready for review March 25, 2022 11:31

Update HACKING.md

579c0e9

Jai-JAP added 2 commits March 25, 2022 19:27

Update build-native.js

360b756

Update build-linux.js

48c06fc

Eugeny merged commit 40e0bcc into Eugeny:master Mar 26, 2022

allcontributors bot mentioned this pull request Mar 26, 2022

docs: add Jai-JAP as a contributor for platform #6019

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for arm platforms #5907

Add support for arm platforms #5907

Jai-JAP commented Mar 8, 2022 •

edited by Eugeny

Loading

Eugeny commented Mar 8, 2022

Jai-JAP commented Mar 9, 2022 •

edited

Loading

Issues-translate-bot commented Mar 9, 2022

Jai-JAP commented Mar 9, 2022

Issues-translate-bot commented Mar 9, 2022

Jai-JAP commented Mar 9, 2022 •

edited by unfurl-links bot

Loading

Jai-JAP commented Mar 9, 2022 •

edited

Loading

Jai-JAP commented Mar 9, 2022

Eugeny commented Mar 9, 2022 •

edited

Loading

Jai-JAP commented Mar 9, 2022

Jai-JAP commented Mar 25, 2022

Jai-JAP commented Mar 25, 2022

Jai-JAP commented Mar 25, 2022

Jai-JAP commented Mar 25, 2022

Eugeny commented Mar 25, 2022

theofficialgman commented Mar 25, 2022 •

edited

Loading

Jai-JAP commented Mar 26, 2022

Eugeny commented Mar 26, 2022 •

edited

Loading

allcontributors bot commented Mar 26, 2022

Eugeny commented Mar 26, 2022

allcontributors bot commented Mar 26, 2022

Eugeny commented Apr 5, 2022

Jai-JAP commented Apr 5, 2022 •

edited

Loading

Jai-JAP commented Apr 6, 2022

Jai-JAP commented Apr 6, 2022

Jai-JAP commented Apr 6, 2022 •

edited

Loading

mirogl commented Apr 21, 2022

Jai-JAP commented Apr 21, 2022 •

edited

Loading

Jai-JAP commented Apr 21, 2022

Jai-JAP commented Apr 21, 2022

mirogl commented Apr 21, 2022

Jai-JAP commented Apr 22, 2022

Add support for arm platforms #5907

Add support for arm platforms #5907

Conversation

Jai-JAP commented Mar 8, 2022 • edited by Eugeny Loading

Eugeny commented Mar 8, 2022

Jai-JAP commented Mar 9, 2022 • edited Loading

Issues-translate-bot commented Mar 9, 2022

Jai-JAP commented Mar 9, 2022

Issues-translate-bot commented Mar 9, 2022

Jai-JAP commented Mar 9, 2022 • edited by unfurl-links bot Loading

Jai-JAP commented Mar 9, 2022 • edited Loading

Jai-JAP commented Mar 9, 2022

Eugeny commented Mar 9, 2022 • edited Loading

Jai-JAP commented Mar 9, 2022

Jai-JAP commented Mar 25, 2022

Jai-JAP commented Mar 25, 2022

Jai-JAP commented Mar 25, 2022

Jai-JAP commented Mar 25, 2022

Eugeny commented Mar 25, 2022

theofficialgman commented Mar 25, 2022 • edited Loading

Jai-JAP commented Mar 26, 2022

Eugeny commented Mar 26, 2022 • edited Loading

allcontributors bot commented Mar 26, 2022

Eugeny commented Mar 26, 2022

allcontributors bot commented Mar 26, 2022

Eugeny commented Apr 5, 2022

Jai-JAP commented Apr 5, 2022 • edited Loading

Jai-JAP commented Apr 6, 2022

Jai-JAP commented Apr 6, 2022

Jai-JAP commented Apr 6, 2022 • edited Loading

mirogl commented Apr 21, 2022

Jai-JAP commented Apr 21, 2022 • edited Loading

Jai-JAP commented Apr 21, 2022

Jai-JAP commented Apr 21, 2022

mirogl commented Apr 21, 2022

Jai-JAP commented Apr 22, 2022

Jai-JAP commented Mar 8, 2022 •

edited by Eugeny

Loading

Jai-JAP commented Mar 9, 2022 •

edited

Loading

Jai-JAP commented Mar 9, 2022 •

edited by unfurl-links bot

Loading

Jai-JAP commented Mar 9, 2022 •

edited

Loading

Eugeny commented Mar 9, 2022 •

edited

Loading

theofficialgman commented Mar 25, 2022 •

edited

Loading

Eugeny commented Mar 26, 2022 •

edited

Loading

Jai-JAP commented Apr 5, 2022 •

edited

Loading

Jai-JAP commented Apr 6, 2022 •

edited

Loading

Jai-JAP commented Apr 21, 2022 •

edited

Loading