-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for arm platforms #5907
Conversation
Looking great, can't wait to test 👍 |
Quick Status update: |
Quick Status update: |
Quick Status update: |
Quick Status update: |
Here are the build artifacts
|
@Eugeny
|
Windows arm64 is untested |
That means that Node couldn't load the
and running it as P.S. the module is built by |
The output of yarn electron 1.js
|
Windows arm64 builds are confirmed working |
Linux arm builds compiled by me on a RPi4 are located at https://github.com/jai-jap/tabby-arm-builds/releases |
Build artifacts for the latest commit can be found here Windows arm64 portable is known working but the installer should also work as building arm64 is supported natively on Windows and Mac OS by electron |
This is now ready to merge in my view |
Fantastic 👍 Is the |
I don't see why the Jai-JAP says the electron downgrade is necessary.
|
Yes since for electron >= 17.0.1 compiling v8 engine results in error same as in this comment |
Got it - fantastic work! |
I couldn't determine any contributions to add, did you specify any contributions? |
@allcontributors please add @Jai-JAP for platform |
I've put up a pull request to add @Jai-JAP! 🎉 |
I will check this later as i am busy with exams. Maybe it will take 1 or 2 days |
Line 6 in 95ae4b8
the ?? in this line seems to be the issue. I think it should be || Also the brackets may be the issue too |
Probably fixed in #6106 |
Hi, C:\Users\miros\Downloads\tabby> But i don't get any Window. I habe a Surface Pro X with SQ2 Arm64 processor and Windows 11 Version 10.0.22000 Build 22000 Thanks |
@mirogl Can you try adding Also let's continue this in a new issue if this doesn't work |
Also if it doesn't work delete all tabby folders in %APPDATA% and also in downloads and try again |
@Eugeny this is not related to tabby and is likely an issue with electron/chromium itself. See electron/electron#32317 |
Hi,thanks - i deleted %APPDATTA%\tabby and the existing Folder under Downloads. After a Reboot i unpacked tabby-1.0.176-portable-arm64.zip and created a emoty data direcoty in the extracted dir. Still hangs at: C:\Users\miros\Downloads\tabby-1.0.176-portable-arm64> Cheers |
@mirogl can you open a new issue with all details |
Add support for
Closes #3947, #2694, #1492