Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After debugging I found the crash on win7 is caused by
DwmEnableBlurBehindWindow
inwindow.ts
.window.ts
passthis.window
towindows-blurbehind
, thenwindows-blurbehind
pass this object tonode::Buffer::Data
:https://github.com/Eugeny/windows-blurbehind/blob/30a3dd4f357493d796c1e4770f478bdf6840d4af/src/blurbehind.cc#L7
node::Buffer::Data
found it's not aArrayBufferView
and crash:https://github.com/nodejs/node/blob/v16.13.0/src/node_buffer.cc#L246
Tabby 1.0.167 uses electron 13.5.1, I don't know why it works. According to electron docs, here should use
win.getNativeWindowHandle()
to getBuffer
of window handle.Fixes #5339, #5465, #5528, #5794