Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve profile groups collapse state. #6046

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Conversation

artu-ole
Copy link
Contributor

Small quality of life improvement to remember which profile groups were collapsed.

Motivation:
I have many different connection profiles in many different groups that need to be modified/copied quite often hence starting at a partially collapsed view allows me to pickup where I stopped last time and ignore less relevant profiles easier.

@Eugeny
Copy link
Owner

Eugeny commented Mar 29, 2022

Thanks! This is looking great, but should use LocalStorage instead of the config file. Storing small things like these in the config will mean that e.g. a config sync will get triggered every time you open/close a group.

@artu-ole
Copy link
Contributor Author

Yep, good point, I also didn't like how refresh would run every time it toggled, but was trying to use same tools already used in the component. I'll change this to use localStorage

@artu-ole
Copy link
Contributor Author

Fixed the storage, let me know if there's anything else I can improve.

use local storage rather than config store
Remove config save and toggleGroupCollapse not to be async
@Eugeny Eugeny merged commit 65ef8cd into Eugeny:master Mar 29, 2022
@Eugeny
Copy link
Owner

Eugeny commented Mar 29, 2022

Looking great now - thanks a lot!

@allcontributors please add @artu-ole for code

@allcontributors
Copy link
Contributor

@Eugeny

I've put up a pull request to add @artu-ole! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants