fix Eugeny/tabby#7254 - config sync replace ngModelChange by keydown enter #7791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution and sorry for the delay! @all-contributors please add @Clem-Fern for code |
|
I couldn't determine any contributions to add, did you specify any contributions? I've put up a pull request to add @Clem-Fern! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, thank's for the work on Tabby. I really love it !
I encountered the same problem as the one describe in the issue #7254.
This fix seems acceptable to me since we don't need to save the config and test the connection on each inserted or removed character in the host and token input field. But i possibly missed something so feel free to ask me if any change needed :)