Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish typings for tabby-ssh #7844

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

elizabeth-dev
Copy link

I'm developing a small plugin for Tabby (one that fetches instance data from AWS in order to make it easier to start SSH connections), and I found out that, even though the tabby-ssh plugin is written in Typescript and has typings declared in the package.json, those typings are not included when publishing the package. This makes development of plugins that consume the tabby-ssh plugin API a bit harder.

This change includes the typings folder in the tabby-ssh package, so the Typescript type definition files are bundled in it.

To be honest this probably should be done for all the plugins in this repo, but I've only checked tabby-ssh. I'm open to include those other plugins in this PR if you consider that useful.

@elizabeth-dev
Copy link
Author

Additionally to the PR, I'm having trouble having my provider injected as a SSH Importer, even though I'm extending SSHProfileImporter. Is creating custom SSH Importers not supported? If it's not, would you be open to supporting it?

@Eugeny Eugeny merged commit 7ab1d4b into Eugeny:master Jan 29, 2023
@Eugeny
Copy link
Owner

Eugeny commented Jan 29, 2023

Thank you for the contribution! I've published the new version with typings.

Make sure you're exposing your importer in your plugin's module description, like it's done here: https://github.com/Eugeny/tabby/blob/master/tabby-electron/src/index.ts#L35-L36

GitHub
A terminal for a more modern age. Contribute to Eugeny/tabby development by creating an account on GitHub.

@elizabeth-dev
Copy link
Author

elizabeth-dev commented Jan 29, 2023

I actually used that as a reference, so I did everything the same way... I must be missing something

The (WIP) code for what I'm developing is here:
https://github.com/elizabeth-dev/tabby-aws/blob/main/src/index.ts#L18

(In any case I know this isn't the place to ask for help, so sorry for that, I guess I'll just keep trying)

GitHub
Contribute to elizabeth-dev/tabby-aws development by creating an account on GitHub.

@Eugeny
Copy link
Owner

Eugeny commented Jan 29, 2023

Found it - the SSH importers list was finalized too early, before external plugins got loaded - it's fixed now in the nightly (make sure you update your tabby-ssh dependency as well!)

I'm actually seeing my AWS hosts with the plugin now 👍

@elizabeth-dev
Copy link
Author

Yayyyyy, thank you 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants