Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Eugeny/tabby#8154 : search panel counter starts from 0 #8198

Merged
merged 3 commits into from
Apr 10, 2023
Merged

fix Eugeny/tabby#8154 : search panel counter starts from 0 #8198

merged 3 commits into from
Apr 10, 2023

Conversation

Clem-Fern
Copy link
Contributor

Hi @Eugeny, hope you're doing well :)

This PR aims to fix the issue #8154

@Eugeny
Copy link
Owner

Eugeny commented Apr 10, 2023

Thanks! It should probably be state.resultIndex ?? 1 + 1 though (in case state.resultIndex is null)

@Clem-Fern
Copy link
Contributor Author

Clem-Fern commented Apr 10, 2023 •
edited
Loading

Oh yeah absolutely! my bad... I was not seeing the problem like that.
So i think the fix should be (state.resultIndex ?? 0) + 1. Otherwise, it seems that the plus operator only affect the fallback value.

@Eugeny
Copy link
Owner

Eugeny commented Apr 10, 2023

Right - LGTM now!

@Eugeny Eugeny merged commit 7da2a15 into Eugeny:master Apr 10, 2023
@Clem-Fern Clem-Fern deleted the fix#8154 branch April 15, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Clem-Fern @Eugeny