-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross Compile linux armhf/arm64 artifacts #8613
Conversation
This PR is now Ready to Merge |
WOW amazing work @Jai-JAP ! |
@Eugeny have you seen any error as below. I incurred this when trying to get builds with node18 with an even better alternative method. Error log
And do you have discord or any other social media where I can DM you to discuss these and keep these threads clean. |
No, haven't seen this before. Can you maybe check if there's a newer keytar version available? |
btw I'm only on twitter (in my profile) but IMO Github is better for this :) |
@Eugeny
This (finally!!) implements a better way to compile tabby for arm linux platforms than docker, quite complex than before but faster.
Completes in ~25-35 mins as compared to ~2 hours with docker based compilation method used previously.
EDIT: Also added AppImage target for linux
Previous approach is still left commented in place.
TESTED working on both arm64 and armhf
Also updated dependency from
@tabby-gang/node-pty
tonote-pty
as it has a new beta release in March. (Feel free to discard this.)Add better cross-compilation support to
scripts/vars.mjs
Prefer squash merge on this PR due to its dirty commit history.