Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix#9262: Jump host selection shows group id instead of group name #9264

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Fix#9262: Jump host selection shows group id instead of group name #9264

merged 2 commits into from
Dec 1, 2023

Conversation

Clem-Fern
Copy link
Contributor

@Clem-Fern Clem-Fern commented Nov 21, 2023 •
edited

Hey @Eugeny,

In ssh profile settings component:

3794081 -> use getProfiles method from ProfilesService instead of accessing through ConfigService store.

f80db81 -> resolve group name in getJumpHostLabel (Fix #9262)

@Eugeny
Copy link
Owner

Eugeny commented Dec 1, 2023

Sorry for the delay, LGTM 👍

@Eugeny Eugeny merged commit 9f6263f into Eugeny:master Dec 1, 2023
10 checks passed
@Clem-Fern Clem-Fern deleted the fix#9262 branch December 1, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jump host selection shows group id instead of group name
2 participants
@Clem-Fern @Eugeny