Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add implicit CR and implicit LF for serial terminal similar to putty #9307

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

kimbob13
Copy link
Contributor

@kimbob13 kimbob13 commented Dec 6, 2023

Hello,
Firstly, I've tried several terminal programs for serial connection, and I've found the tabby is really satisfying experience for me,
so thanks for the great development.

The one thing I missed from other programs is the "Implicit CR in every LF" and "Implicit LF in every CR features, which can be found in like putty.
That is, the tabby has a feature for "Force CRLF", but I want to add a CR only in LF, not adding LF in CR.

Therefore, this PR adds following two setting entries for new line modes in serial connection.

  • Imiplicit CR: Only add CR in LF
  • Implicit LF: Only add LF in CR

@kimbob13 kimbob13 changed the title add implicit cr and implicit lf for serial terminal similar to putty add implicit CR and implicit LF for serial terminal similar to putty Dec 6, 2023
@Eugeny
Copy link
Owner

Eugeny commented Dec 6, 2023

Thank you for the contribution! @all-contributors please add @kimbob13 for code

@Eugeny Eugeny merged commit a4aa07c into Eugeny:master Dec 6, 2023
10 checks passed
Copy link
Contributor

@Eugeny

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @kimbob13! 🎉

@kimbob13 kimbob13 deleted the implicit-cr-lf branch December 6, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants