Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add setting to hide tray (menubar for macos) #9624

Merged
merged 3 commits into from
Jun 19, 2024
Merged

add setting to hide tray (menubar for macos) #9624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9425920
add setting to hide tray (menubar for macos)
C41M50N May 7, 2024
439a7a8
move 'show tray' setting to window settings
C41M50N Jun 17, 2024
8a49c73
change from 'show tray' to 'hide tray'
C41M50N Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/lib/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,10 @@ export class Application {
}

enableTray (): void {
if (!!this.tray || process.platform === 'linux') {
if (!!this.tray || process.platform === 'linux' || (this.configStore.hideTray ?? false) === true) {
return
}

if (process.platform === 'darwin') {
this.tray = new Tray(`${app.getAppPath()}/assets/tray-darwinTemplate.png`)
this.tray.setPressedImage(`${app.getAppPath()}/assets/tray-darwinHighlightTemplate.png`)
Expand Down
8 changes: 8 additions & 0 deletions locale/en-GB.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2036,6 +2036,10 @@ msgstr ""
msgid "Show Serial connections"
msgstr ""

#: locale/tmp-html/tabby-settings/src/components/windowSettingsTab.component.html:73
msgid "Hide Tabby in tray or menu bar."
msgstr ""

#: locale/tmp-html/tabby-settings/src/components/windowSettingsTab.component.html:152
msgid "Show tabs in fullscreen mode"
msgstr ""
Expand All @@ -2044,6 +2048,10 @@ msgstr ""
msgid "Show toolbar"
msgstr ""

#: locale/tmp-html/tabby-settings/src/components/windowSettingsTab.component.html:73
msgid "Hide tray"
msgstr ""

#: locale/tmp-html/tabby-settings/src/components/vaultSettingsTab.component.html:45
msgid "Show vault contents"
msgstr ""
Expand Down
1 change: 1 addition & 0 deletions tabby-core/src/configDefaults.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ enableWelcomeTab: true
electronFlags:
- ['force_discrete_gpu', '0']
enableAutomaticUpdates: true
hideTray: false
version: 1
vault: null
encrypted: false
Expand Down
9 changes: 9 additions & 0 deletions tabby-settings/src/components/windowSettingsTab.component.pug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,15 @@ h3.mb-3(translate) Window
label.btn.btn-secondary(for='frameFull')
span(translate) Full

.form-line(*ngIf='hostApp.platform !== Platform.Web && hostApp.platform !== Platform.Linux')
.header
.title(translate) Hide tray
.description(translate) Hide Tabby in tray or menu bar.
toggle(
[(ngModel)]='config.store.hideTray',
(ngModelChange)='saveConfiguration(true)'
)

h3.mt-4(translate) Docking

.form-line(*ngIf='docking')
Expand Down
Loading