Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wsl: Get the distro icon from the package family name #9749

Merged
merged 1 commit into from
Jul 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"electron-updater": "^5.2.1",
"fontmanager-redux": "1.1.0",
"glasstron": "0.1.1",
"node-powershell": "5.0.1",
"js-yaml": "4.1.0",
"keytar": "^7.9.0",
"mz": "^2.7.0",
Expand Down
6 changes: 5 additions & 1 deletion tabby-core/src/components/profileIcon.component.pug
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
.icon(
[fastHtmlBind]='pngPath',
*ngIf='!isHTML && isPNG'
)
i.icon(
class='fa-fw {{icon}}',
[style.color]='color',
*ngIf='!isHTML'
*ngIf='!isHTML && !isPNG'
)
.icon(
[fastHtmlBind]='icon',
Expand Down
8 changes: 8 additions & 0 deletions tabby-core/src/components/profileIcon.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,15 @@ export class ProfileIconComponent extends BaseComponent {
@Input() icon?: string
@Input() color?: string

get pngPath (): string {
return `<img src="${this.icon?.trim()}" width="16" height="16" />`
}

get isHTML (): boolean {
return this.icon?.startsWith('<') ?? false
}

get isPNG (): boolean {
return this.icon?.endsWith('.png') ?? false
}
}
42 changes: 40 additions & 2 deletions tabby-electron/src/shells/wsl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import { HostAppService, Platform, isWindowsBuild, WIN_BUILD_WSL_EXE_DISTRO_FLAG

import { ShellProvider, Shell } from 'tabby-local'

import { PowerShell } from 'node-powershell'

/* eslint-disable block-scoped-var */

try {
Expand Down Expand Up @@ -38,10 +40,42 @@ const wslIconMap: Record<string, string> = {
/** @hidden */
@Injectable()
export class WSLShellProvider extends ShellProvider {
private _pwsh: PowerShell

constructor (
private hostApp: HostAppService,
) {
super()

// make sure that this will not use the powershell profile
// that may take a long time to load
this._pwsh = new PowerShell({
executableOptions: {
'-NoProfile': true,
},
})
}

private async _resolveIcon (defaultDistKey: any): Promise<string> {
let _icon = wslIconMap.Linux

// check if the register has PackageFamilyName
if (defaultDistKey.PackageFamilyName) {
// get the icon from the package family name
const packageFamilyName = (defaultDistKey.PackageFamilyName.value as string).split('_')[0]

if (packageFamilyName) {
const _ret = await this._pwsh.invoke(`Get-AppxPackage ${packageFamilyName} | ConvertTo-Json`)

if (!_ret.hadErrors && _ret.stdout?.toString() !== undefined && _ret.stdout.toString() !== '') {
const appx = JSON.parse(_ret.stdout.toString())
const installationLocation = appx.InstallLocation
_icon = `${installationLocation}\\Assets\\Square44x44Logo.targetsize-16.png`
}
}
}

return _icon
}

async provide (): Promise<Shell[]> {
Expand All @@ -59,6 +93,7 @@ export class WSLShellProvider extends ShellProvider {
if (lxss?.DefaultDistribution) {
const defaultDistKey = wnr.getRegistryKey(wnr.HK.CU, lxssPath + '\\' + String(lxss.DefaultDistribution.value))
if (defaultDistKey?.DistributionName) {
const _icon = await this._resolveIcon(defaultDistKey)
const shell: Shell = {
id: 'wsl',
name: 'WSL / Default distro',
Expand All @@ -68,7 +103,7 @@ export class WSLShellProvider extends ShellProvider {
COLORTERM: 'truecolor',
},
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
icon: wslIconMap[defaultDistKey.DistributionName.value] ?? wslIconMap.Linux,
icon: wslIconMap[defaultDistKey.DistributionName.value] ?? _icon,
}
shells.push(shell)
}
Expand All @@ -90,11 +125,14 @@ export class WSLShellProvider extends ShellProvider {
return []
}
}

for (const child of wnr.listRegistrySubkeys(wnr.HK.CU, lxssPath) as string[]) {
const childKey = wnr.getRegistryKey(wnr.HK.CU, lxssPath + '\\' + child)
if (!childKey.DistributionName || !childKey.BasePath) {
continue
}

const _icon = await this._resolveIcon(childKey)
const wslVersion = (childKey.Flags?.value || 0) & 8 ? 2 : 1
const name = childKey.DistributionName.value
const fsBase = wslVersion === 2 ? `\\\\wsl$\\${name}` : childKey.BasePath.value as string + '\\rootfs'
Expand All @@ -110,7 +148,7 @@ export class WSLShellProvider extends ShellProvider {
COLORTERM: 'truecolor',
},
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
icon: wslIconMap[name] ?? wslIconMap.Linux,
icon: wslIconMap[name] ?? _icon,
}
shells.push(shell)
}
Expand Down
Loading