Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SetBaseURL() #25

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Remove SetBaseURL() #25

merged 1 commit into from
Nov 30, 2020

Conversation

Eun
Copy link
Owner

@Eun Eun commented Nov 30, 2020

Description

Problem

SetBaseURL() was defunct because of the recent Request() changes.

Solution

Remove SetBaseURL() because we can always use hit.Do(BaseURL()).

Notes

Other notes that you want to share but do not fit into Problem or Solution.

Checklist

  • Ran make test
  • Review README.md go //ignore sections
  • Added Changelog entry to README.md when this is a #major or #minor release.

@Eun Eun merged commit 6f6280a into master Nov 30, 2020
@Eun Eun deleted the remove-defunct-SetBaseURL() branch November 30, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Eun