Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:更换图片下载方式,修复点击下载之后跳转新标签页但不发起下载的问题 #86

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

czh1998yr
Copy link
Contributor

@czh1998yr czh1998yr commented Jul 8, 2023

🤔 这个变动的性质是? (至少选中一项)

  • [*] 日常 bug 修复
  • 新特性提交
  • 组件样式/交互改进
  • 重构
  • 代码风格优化
  • 包体积优化
  • 性能优化
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

通过测试发现,点击下载之后会跳转到新页面,但没有发起下载请求,削减了用户体检

💡 需求背景和解决方案

在原来的基础之前,更换成请求的放下再下载,避免上述问题

📝 更新日志

更换图片下载方式,修复点击下载之后跳转新标签页但不发起下载的问题

语言 更新描述
🇺🇸 英文
🇨🇳 中文 *

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • [*] 文档已补充或无须补充
  • [*] 代码演示已提供或无须提供
  • [*] TypeScript 定义已补充或无须补充
  • [*] Changelog 已提供或无须提供

🚀 概述

copilot:summary

🔍 实现细节

copilot:walkthrough

@Evansy
Copy link
Owner

Evansy commented Jul 12, 2023

@czh1998yr 这个问题必现的么。

@czh1998yr
Copy link
Contributor Author

@czh1998yr 这个问题必现的么。

是的, 我这边使用Edge和谷歌都是跳转到新标签页,然后没有下载行为

@Evansy
Copy link
Owner

Evansy commented Jul 14, 2023

@czh1998yr 这个问题必现的么。

是的, 我这边使用Edge和谷歌都是跳转到新标签页,然后没有下载行为

你的 edge/chrome 什么版本的呀,我刚测试了正常的。

@czh1998yr
Copy link
Contributor Author

1

@czh1998yr
Copy link
Contributor Author

2

Copy link
Owner

@Evansy Evansy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢 PR~

@Evansy Evansy merged commit 8eb46a4 into Evansy:main Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants