Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Persistent Subscription naming and behaviour with RFC-022 - gRPC Persistent Subscriptions #164

Closed
oskardudycz opened this issue Nov 3, 2021 · 0 comments · Fixed by #198
Closed

Align Persistent Subscription naming and behaviour with RFC-022 - gRPC Persistent Subscriptions #164

oskardudycz opened this issue Nov 3, 2021 · 0 comments · Fixed by #198
Labels
rfc/022 tier/minimum-viable

Comments

@oskardudycz
Copy link
Contributor

oskardudycz commented Nov 3, 2021 •
edited by tambeau
Loading

As the next release will be breaking, then we could use it to align the naming and behaviour with what was agreed in the RFC-022 - gRPC Persistent Subscriptions. Current parameters names are not aligned.

RFC-022

Original Issue

We can also consider doing that non-breaking by marking the old names as obsolete and passing the getters and setters to the new options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rfc/022 tier/minimum-viable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align persistent subscription names with RFC EventStore/EventStore-Client-Dotnet
2 participants
@hayley-jean @oskardudycz