Persistent subscriptions to $all #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaan1337
force-pushed
the
psub-to-all
branch
7 times, most recently
from
d925a61 to
60ab98a
Compare
hayley-jean
previously approved these changes
Apr 29, 2021
hayley-jean
previously approved these changes
May 3, 2021
YoEight
previously approved these changes
May 5, 2021
shaan1337
force-pushed
the
psub-to-all
branch
2 times, most recently
from
a455a29 to
35049d7
Compare
Update persistent subscriptions proto file Make StreamPosition and Position implement new interface: IPosition Convert `StreamPosition StartFrom` to `IPosition? StartFrom` in PersistentSubscriptionSettings Move SystemStreams.cs from src/EventStore.Client.Streams to src/EventStore.Client and add the $all stream Move SystemMetadata class to a separate file in the EventStore.Client.Streams project Added: Create persistent subscriptions to $all Added: Update persistent subscriptions to $all Added: Delete persistent subscriptions to $all Added: Read from persistent subscriptions to $all Delete no longer valid test: create_on_all_stream.the_completion_fails_with_invalid_stream Update existing tests to use SystemStreams.AllStream/SystemRoles.All instead of "$all" Move all persistent subscription to stream tests to SubscriptionToStream directory Move stream persistent subscription tests to EventStore.Client.SubscriptionToStream namespace Added tests: create persistent subscriptions to $all Added tests: update persistent subscriptions to $all Added tests: delete persistent subscriptions to $all Added tests: connect to persistent subscriptions to $all Added tests: ACK/NAK for persistent subscriptions to $all Add the following wrappers to the persistent subscription client: CreateToAllAsync, DeleteToAllAsync, UpdateToAllAsync, SubscribeToAllAsync Update tests to use wrappers: CreateToAllAsync, DeleteToAllAsync, UpdateToAllAsync, SubscribeToAllAsync
Note: Regression tests on this PR should fail until #115 has been merged. |
hayley-jean
approved these changes
May 6, 2021
YoEight
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/EventStore/home/issues/434
Fixes: https://github.com/EventStore/home/issues/435
Client-side PR for : EventStore/EventStore#2869
From the user-perspective, this PR changes the API as follows:
CreateAsync(),UpdateAsync(),DeleteAsync()andSubscribeAsync(),$allcan now be passed as stream name (also defined by constant:SystemStreams.AllStream)CreateToAllAsync(),UpdateToAllAsync(),DeleteToAllAsync()andSubscribeToAllAsync()to make the feature more easily discoverable in the APIstartFrominPersistentSubscriptionSettingsis now anIPosition?(new interface) instead of aStreamPosition?(not a breaking change sinceStreamPositionnow implementsIPosition)Important changes:
SystemStreamsclass has been moved fromsrc/EventStore.Client.Streamstosrc/EventStore.Clientand$allhas been added to it