Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support gRPC Bi-Di Appends on Client #121

Merged
merged 4 commits into from
Jul 8, 2021
Merged

Support gRPC Bi-Di Appends on Client #121

merged 4 commits into from
Jul 8, 2021

Conversation

thefringeninja
Copy link
Contributor

No description provided.

@thefringeninja thefringeninja self-assigned this May 11, 2021
@hayley-jean hayley-jean mentioned this pull request May 21, 2021
Merged
hayley-jean
hayley-jean requested changes Jun 7, 2021
View reviewed changes
Copy link
Member

@hayley-jean hayley-jean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and works on my side. Just a few small issues that need to be addressed

src/EventStore.Client.Streams/EventStoreClient.Append.cs Show resolved Hide resolved
src/EventStore.Client.Streams/MaximumAppendSizeExceededException.cs Show resolved Hide resolved
src/EventStore.Client/EventStore.Client.csproj Outdated Show resolved Hide resolved
src/EventStore.Client.Streams/WriteResultExtensions.cs Show resolved Hide resolved
@hayley-jean
Copy link
Member

We should detect whether the BatchAppend operation isn't supported and fall back to the original Append operation so that this client can still connect to older server versions.

@thefringeninja thefringeninja force-pushed the gho-pro branch 3 times, most recently from edb5cab to cce134e Compare June 29, 2021 08:18
@YoEight
Copy link
Member

YoEight commented Jul 5, 2021

LGTM

@hayley-jean hayley-jean merged commit 58cef11 into EventStore:master Jul 8, 2021
@thefringeninja thefringeninja deleted the gho-pro branch September 15, 2021 08:43
@thefringeninja thefringeninja mentioned this pull request Sep 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayley-jean hayley-jean hayley-jean approved these changes

@YoEight YoEight YoEight approved these changes

@jageall jageall Awaiting requested review from jageall

Assignees

@thefringeninja thefringeninja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thefringeninja @hayley-jean @YoEight @jageall