Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Projection Management Samples for the documentation #143

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Projection Management Samples for the documentation #143

merged 2 commits into from
Aug 17, 2021

Conversation

ylorph
Copy link
Contributor

@ylorph ylorph commented Aug 9, 2021

No description provided.

@ylorph ylorph added the documentation Improvements or additions to documentation label Aug 10, 2021
oskardudycz
oskardudycz requested changes Aug 11, 2021
View reviewed changes
Copy link
Collaborator

@oskardudycz oskardudycz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@ylorph ylorph force-pushed the ylorph/projection-management-sample branch 2 times, most recently from b470c7b to e98992c Compare August 16, 2021 09:44
oskardudycz
oskardudycz previously approved these changes Aug 17, 2021
View reviewed changes
Copy link
Collaborator

@oskardudycz oskardudycz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ylorph approving, but please fix #143 (comment) before merging

@ylorph ylorph force-pushed the ylorph/projection-management-sample branch from 9a504bd to b8b297f Compare August 17, 2021 10:57
@ylorph ylorph requested a review from oskardudycz August 17, 2021 12:37
@hayley-jean hayley-jean merged commit 2891af6 into master Aug 17, 2021
@hayley-jean hayley-jean deleted the ylorph/projection-management-sample branch August 17, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayley-jean hayley-jean hayley-jean approved these changes

@oskardudycz oskardudycz oskardudycz approved these changes

@alexeyzimarev alexeyzimarev Awaiting requested review from alexeyzimarev

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ylorph @hayley-jean @oskardudycz