-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RFC 574 #195
Implement RFC 574 #195
Conversation
a333c54
to
cdcfeec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the size restrictions look good
- adding a
ReconnectionRequired
type looks good
but im suspicious about
- rediscovering on 'aborted' status
- the number of InnerExceptions to dig through - we might need that extra one that was there before because of the typedexceptioninterceptor
5485946
to
ac9b8dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'aborted' thing is resolved now (rfc is adjusted or in the processof)
I think still need to address the number of InnerExceptions we are looking in to find the RpcException, because the TypedExceptionHandler will wrap it in an InvalidOperationException. If I'm right then UNAVAILABLE
will not trigger rediscovery
7946e35
to
cced800
Compare
For documentation we should explain that we aren't wrapping in InvalidOperation exception any more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only couple of tests to update
cced800
to
5cf2ef9
Compare
5cf2ef9
to
efe7bf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait a moment, why are we dropping InvalidOperationException
support? It's also not aligned with a recent @hayley-jean suggestion: https://github.com/EventStore/architecture-and-planning/pull/106
- set grpc.max_receive_message_length to 17MB - force rediscovery only when lost connection or unknown error
efe7bf7
to
cd28eee
Compare
Added: Set
grpc.max_receive_message_length
to 17MBFixed: Force Rediscovery Only when Lost Connection or Unknown error
EventStore allows events of up to 16mb to be written internally. While you can't write events this large through gRPC, you could do so through the TCP client, or through projections. To allow the gRPC clients to read any event that EventStoreDB was able to write, we want to hardcode the max receive message length for all gRPC clients to 17mb.
Some cases where redicovery should have been forced were not handled, are handled now.
Fixes #193