-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscriptions Without Callbacks (DEV-112) #282
Merged
josephcummings
merged 4 commits into
EventStore:master
from
thefringeninja:subscriptions-without-callbacks
Feb 28, 2024
Merged
Subscriptions Without Callbacks (DEV-112) #282
josephcummings
merged 4 commits into
EventStore:master
from
thefringeninja:subscriptions-without-callbacks
Feb 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefringeninja
force-pushed
the
subscriptions-without-callbacks
branch
9 times, most recently
from
February 14, 2024 16:40
c652f07
to
665c012
Compare
thefringeninja
force-pushed
the
subscriptions-without-callbacks
branch
9 times, most recently
from
February 15, 2024 20:11
dcd7760
to
ed78ff1
Compare
thefringeninja
changed the title
[Spike] Subscriptions Without Callbacks
Subscriptions Without Callbacks (DEV-112)
Feb 15, 2024
josephcummings
suggested changes
Feb 16, 2024
src/EventStore.Client.PersistentSubscriptions/EventStorePersistentSubscriptionsClient.Read.cs
Outdated
Show resolved
Hide resolved
src/EventStore.Client.PersistentSubscriptions/EventStorePersistentSubscriptionsClient.Read.cs
Outdated
Show resolved
Hide resolved
thefringeninja
force-pushed
the
subscriptions-without-callbacks
branch
from
February 27, 2024 14:37
2e37e0c
to
23bdb04
Compare
josephcummings
approved these changes
Feb 27, 2024
josephcummings
suggested changes
Feb 27, 2024
src/EventStore.Client.PersistentSubscriptions/EventStorePersistentSubscriptionsClient.Read.cs
Outdated
Show resolved
Hide resolved
thefringeninja
force-pushed
the
subscriptions-without-callbacks
branch
from
February 27, 2024 14:46
23bdb04
to
6d500e9
Compare
thefringeninja
force-pushed
the
subscriptions-without-callbacks
branch
from
February 27, 2024 14:52
6d500e9
to
b5bdf55
Compare
josephcummings
approved these changes
Feb 27, 2024
w1am
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: overloads to subscribe to catchup subscriptions using a simple foreach
Added: overloads to subscribe to persistent subscriptions using a simple foreach
Changed: obsoleted subscription APIs:
SubscribeToAllAsync
andSubscribeToStreamAsync
Changed: obsoleted persistent subscription APIs:
SubscribeToAllAsync
andSubscribeToStreamAsync