-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement connection string #49
Conversation
773c848
to
5b1bc02
Compare
5b1bc02
to
ea3cda7
Compare
Put each connection string exception in an individual file
changes have been made as requested
Let's try and marry up the units to that of the server. |
…ith server parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two things I've found during testing:
- It's possible to provide duplicate values in the connection string. This results in the last one specified taking effect, should we leave this or should this cause an error?
- Perhaps there should be some validation checking for the
?
after specifying the host? There's no error if the?
is omitted, but the settings don't take effect.
@hayley-jean good catch, thanks for the feedback, I've addressed these issues in these 2 commits: |
src/EventStore.Client/EventStoreClientSettings.ConnectionString.cs
Outdated
Show resolved
Hide resolved
Hey @shaan1337, good work on this! |
@pgermishuys yes, the connection string mimics a URL as much as possible and ? is part of the syntax: https://en.wikipedia.org/wiki/URL#Syntax Right now we enforce a ? just after the / but the path could later on point to a specific resource, e.g if we later on support multi-tenancy we could specify the database name in the path: |
e835a46
to
74acd58
Compare
74acd58
to
52ffeab
Compare
@pgermishuys @hayley-jean @thefringeninja |
Fixes #41
Note: This PR has been opened against
use-https-option
branch so that it's retargeted tomaster
after the former is merged.Examples:
All parameters: