Add restarting persistent subscriptions #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayley-jean
previously approved these changes
Jul 31, 2020
thefringeninja
previously approved these changes
Aug 4, 2020
pgermishuys
dismissed stale reviews from thefringeninja and hayley-jean
via
27a1445
pgermishuys
force-pushed
the
restart-persistent-subscriptions
branch
from
ee91872 to
27a1445
Compare
thefringeninja
approved these changes
Aug 5, 2020
hayley-jean
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67
I moved the disruptive client operations (shutdown, resign) into separate test fixtures as they were causing the other tests alongside them to fail.