Keep alives #135
Merged
Keep alives #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add new keepAlive parameter - allow keepAlive to be passed via connectionString
oskardudycz
approved these changes
Feb 10, 2021
George-Payne
force-pushed
the
keep-alives
branch
from
e9d4ff0 to
c37dcd5
Compare
thefringeninja
approved these changes
Feb 12, 2021
oskardudycz
reviewed
Feb 12, 2021
src/__test__/connection/__snapshots__/parseConnectionString.test.ts.snap
Show resolved
Hide resolved
oskardudycz
reviewed
Feb 12, 2021
- add test cases for keepAlive various settings - add invalid test case for keepAliveInterval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keepAliveIntervalis smaller than ten seconds and greater than or equal to 0, then client log a warningfixes: #112