[DEV-204] Upgrade grpc-js to 1.9.12 #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w1am
changed the title
jokesterfr
approved these changes
Nov 23, 2023
w1am
changed the title
|
@jokesterfr, we are experiencing a discrepancy in the error messages sent to us by the grpc-js library after the upgrade. We receive different error messages in CI and latest when the connection is shut down while reading events from a stream. I have submitted a PR to address the potential bug in the grpc repository. In the meantime, you to use the resolutions feature if you are using Yarn, or overrides in npm, to pin to the newer version of grpc-js until the PR is merged. |
w1am
force-pushed
the
fix-versions-and-eslint
branch
2 times, most recently
from
de1b528 to
74cfce1
Compare
- Fix linting issues - Add explanations for the discrepancy in the keepalive ping error
w1am
force-pushed
the
fix-versions-and-eslint
branch
from
909daa4 to
2c62da4
Compare
w1am
changed the title
|
Any plan for a merge of this PR? |
|
@jokesterfr Sorry for taking time to respond. We'll merge it soon. |
George-Payne
approved these changes
Dec 14, 2023
cdevarenne
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed: Upgraded gRPC-JS version from 1.9.0 to 1.9.12.
Fixed: Linting issues
Added: Explanations for the discrepancy in the keepalive ping error. DEV-204