Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to use whatever gRPC implementation they want. #251

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

YoEight
Copy link
Member

@YoEight YoEight commented Nov 2, 2023

Changed: Allow the user to use whatever gRPC implementation they want.

Fixes #249

This patch allows the user to use whatever gRPC implementation they want which is valuable if you want to use the client in Android for example. As a consequence, users will have to import grpc-netty, grpc-netty-shaded or grpc-okhttp depending on their situation.

@YoEight
Copy link
Member Author

YoEight commented Nov 3, 2023

I would put that PR on hold because I'm unable to disable certificate verification using Grpc.newChannelBuilderForAddress and TlsChannelCredentials only. Setting a custom insecure trust manager and a hostname verifier do absolutely nothing. Will investigate what the folks working on grpc-netty-shaded did to make that possible.

@YoEight YoEight added the blocked label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConnectionState.connect() should use generic Grpc.newChannelBuilderForAddress()
1 participant