Skip to content

Commit

Permalink
Remove task not ready traces which are cluttering the file
Browse files Browse the repository at this point in the history
  • Loading branch information
Jay Chia committed Oct 29, 2024
1 parent 0d090ec commit 0af74f3
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 16 deletions.
5 changes: 1 addition & 4 deletions daft/runners/ray_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,7 @@ def _await_tasks(
timeout = 0.01
num_returns = len(inflight_ref_to_task_id)
with runner_tracer.awaiting(num_returns, timeout):
readies, not_readies = ray.wait(
readies, _ = ray.wait(
list(inflight_ref_to_task_id.keys()),
num_returns=num_returns,
timeout=timeout,
Expand All @@ -808,9 +808,6 @@ def _await_tasks(
if ready in inflight_ref_to_task_id:
task_id = inflight_ref_to_task_id[ready]
runner_tracer.task_received_as_ready(task_id, inflight_tasks[task_id].stage_id)
for not_ready in not_readies:
if not_ready in inflight_ref_to_task_id:
runner_tracer.task_not_ready(inflight_ref_to_task_id[not_ready])

return readies

Expand Down
12 changes: 0 additions & 12 deletions daft/runners/ray_tracing.py
Original file line number Diff line number Diff line change
Expand Up @@ -503,18 +503,6 @@ def task_dispatched(self, task_id: str):
}
)

def task_not_ready(self, task_id: str):
self._write_event(
{
"id": task_id,
"category": "task",
"name": "task_awaited_not_ready",
"ph": PHASE_ASYNC_INSTANT,
"pid": 1,
"tid": 1,
}
)

def task_received_as_ready(self, task_id: str, stage_id: int):
self._write_event(
{
Expand Down

0 comments on commit 0af74f3

Please sign in to comment.