comment

Eventual-Inc · Oct 23, 2024 · 86e1f62 · 86e1f62
1 parent 579e359
commit 86e1f62
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/daft/sql/sql_scan.py b/daft/sql/sql_scan.py
@@ -161,7 +161,8 @@ def _get_num_rows(self) -> int:
 
     def _attempt_partition_bounds_read(self, num_scan_tasks: int) -> tuple[Any, PartitionBoundStrategy]:
         try:
-            # Try to get percentiles using percentile_cont
+            # Try to get percentiles using percentile_disc.
+            # Favor percentile_disc over percentile_cont because we want exact values to do <= and >= comparisons.
             percentiles = [i / num_scan_tasks for i in range(num_scan_tasks + 1)]
             # Use the OVER clause for SQL Server
             over_clause = "OVER ()" if self.conn.dialect in ["mssql", "tsql"] else ""