Skip to content

Commit

Permalink
Add Pyarrow 6.0 in matrix for CI testing (#945)
Browse files Browse the repository at this point in the history
  • Loading branch information
samster25 authored May 21, 2023
1 parent daf26c0 commit c644c96
Showing 1 changed file with 17 additions and 6 deletions.
23 changes: 17 additions & 6 deletions .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,14 @@ jobs:
fail-fast: false
matrix:
python-version: ['3.7', '3.10']
daft_runner: [py, ray]
daft-runner: [py, ray]
pyarrow-version: [6.0.1, 12.0]
exclude:
- daft-runner: ray
pyarrow-version: 6.0.1
- daft-runner: py
python-version: '3.10'

steps:
- uses: actions/checkout@v3
- uses: moonrepo/setup-rust@v0
Expand Down Expand Up @@ -53,6 +60,10 @@ jobs:
pip install --upgrade pip
pip install -r requirements-dev.txt
- name: Override pyarrow
if: ${{ matrix.pyarrow-version }}
run: pip install pyarrow==${{ matrix.pyarrow-version }}

- name: Build library and Test with pytest
run: |
source activate
Expand All @@ -63,10 +74,10 @@ jobs:
maturin develop
mkdir -p report-output && pytest --cov=daft --ignore tests/integration --durations=50
coverage combine -a --data-file='.coverage' || true
coverage xml -o ./report-output/coverage-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.daft_runner }}.xml
cargo llvm-cov --no-run --lcov --output-path report-output/rust-coverage-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.daft_runner }}.lcov
coverage xml -o ./report-output/coverage-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.daft-runner }}.xml
cargo llvm-cov --no-run --lcov --output-path report-output/rust-coverage-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.daft-runner }}.lcov
env:
DAFT_RUNNER: ${{ matrix.daft_runner }}
DAFT_RUNNER: ${{ matrix.daft-runner }}

- name: Upload coverage report
uses: actions/upload-artifact@v3
Expand Down Expand Up @@ -101,7 +112,7 @@ jobs:
fail-fast: false
matrix:
python-version: ['3.7']
daft_runner: [py, ray]
daft-runner: [py, ray]
steps:
- uses: actions/checkout@v3
- uses: moonrepo/setup-rust@v0
Expand Down Expand Up @@ -151,7 +162,7 @@ jobs:
maturin develop --release
pytest tests/integration/ --durations=50
env:
DAFT_RUNNER: ${{ matrix.daft_runner }}
DAFT_RUNNER: ${{ matrix.daft-runner }}

- name: Send Slack notification on failure
uses: slackapi/slack-github-action@v1.24.0
Expand Down

0 comments on commit c644c96

Please sign in to comment.