-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] Implement growables for array types #1287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d748cb6
to
07a5d48
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1287 +/- ##
==========================================
+ Coverage 87.32% 87.35% +0.03%
==========================================
Files 61 61
Lines 6049 6049
==========================================
+ Hits 5282 5284 +2
+ Misses 767 765 -2 |
c1e4fae
to
0d0b7e0
Compare
653c84e
to
0196669
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Growables are generally useful for abstracting "physical" operations such as:
This will become much more important as we add new Array types (FixedSizeListArray, StructArray etc). These arrays can just implement their own Growable classes, and implementations for the physical kernels will be easy to implement.
Changes
Growable<Arr>
trait that is a growable to build the specifiedArr
GrowableArray
trait which is implemented byDataArray
andLogicalArray
: these types can now create a growable using their associated::make_growable
functionsif_else
to use the new growables, reducing quite a bit of code and nasty macro usage