Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add ability to specify snapshot_id for iceberg read #2426

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Jun 20, 2024

Closes #2400

@github-actions github-actions bot added the enhancement New feature or request label Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.13%. Comparing base (3aeba6f) to head (75acee6).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2426      +/-   ##
==========================================
+ Coverage   63.12%   63.13%   +0.01%     
==========================================
  Files         938      939       +1     
  Lines      105269   105328      +59     
==========================================
+ Hits        66449    66504      +55     
- Misses      38820    38824       +4     
Files Coverage Δ
daft/iceberg/iceberg_scan.py 63.86% <100.00%> (+0.30%) ⬆️
daft/io/_iceberg.py 85.71% <100.00%> (ø)

... and 12 files with indirect coverage changes

@jaychia jaychia merged commit 4951842 into main Jun 21, 2024
45 checks passed
@jaychia jaychia deleted the jay/iceberg-snapshot-id branch June 21, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Iceberg Time Travel Support
1 participant