[FEAT] Changes the default count() behavior to perform a global row count instead #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaychia
changed the title
jaychia
force-pushed
the
jay/count-behavior
branch
from
edd187c to
4a1bc88
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2653 +/- ##
=======================================
Coverage ? 63.74%
=======================================
Files ? 979
Lines ? 111536
Branches ? 0
=======================================
Hits ? 71104
Misses ? 40432
Partials ? 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1996
Our new
df.count()behavior will be similar toSELECT COUNT(*)in SQL, returning a new dataframe with a single"count"column.