[FEAT] Allow user provided schema and schema inference length for read_sql #2676
+263
−74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables users to provide a
schema
to read_sql, as well as aninfer_schema
flag to turn on/off inference, andinfer_schema_length
to customize the length of the scan for inference.Note that
infer_schema_length
only applies when SQLAlchemy is used to read, otherwise ConnectorX is able to provide the schema with alimit=0
as it is an arrow backed driver. This is a new optimization.This PR also has a few refactors, namely moving the
construct_sql_query
and theread_schema
logic to the SQLConnection object instead of the ScanOperator. This is so that schema inference also has context on the driver that will be used.