-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] Add check for stateful UDF outside of project #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2771 will degrade performances by 55.47%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2771 +/- ##
=======================================
Coverage ? 63.26%
=======================================
Files ? 1001
Lines ? 113771
Branches ? 0
=======================================
Hits ? 71980
Misses ? 41791
Partials ? 0
|
jaychia
approved these changes
Aug 30, 2024
src/daft-plan/src/logical_optimization/rules/push_down_projection.rs
Outdated
Show resolved
Hide resolved
✅ Deploy Preview for daft-docs canceled.
|
jaychia
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a parameter to
resolve_expr
and its related functions to allow for stateful UDFs in the expression. This is set to false everywhere except for projects.Additionally,
df['column name']
used to callresolve_exprs
to check for validity and returned its output, which would be problematic if there were wildcards in the expression. Now, I've created a function that only does the validity check, andDataFrame.__getitem__
would just returncol(name)
, which will be actually resolved later in the builder.