Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: add partitioning_* functions to sql #2869

Merged
merged 2 commits into from
Sep 24, 2024
Merged

[FEAT]: add partitioning_* functions to sql #2869

merged 2 commits into from
Sep 24, 2024

Conversation

universalmind303
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Sep 20, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 20, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2869 will not alter performance

Comparing universalmind303:sql-partitioning-funcs (a931b06) with main (fd42281)

Summary

✅ 17 untouched benchmarks

@kevinzwang
Copy link
Member

@universalmind303 could you wait until #2842 to merge this? I made a few changes to our partitioning functions

@jaychia jaychia removed their request for review September 23, 2024 17:06
raunakab
raunakab reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@raunakab raunakab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question about length checking for specific cases.

src/daft-sql/src/modules/partitioning.rs Show resolved Hide resolved
@universalmind303 universalmind303 merged commit e3dd671 into Eventual-Inc:main Sep 24, 2024
36 checks passed
@universalmind303 universalmind303 deleted the sql-partitioning-funcs branch January 23, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinzwang kevinzwang Awaiting requested review from kevinzwang

@raunakab raunakab Awaiting requested review from raunakab

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@universalmind303 @kevinzwang @raunakab