[FEAT] Add floor division #3064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #3064 will not alter performanceComparing Summary
|
|
assigning @colin-ho for review |
colin-ho
reviewed
Oct 18, 2024
| expr = Expression._to_expression(other) | ||
| return Expression._from_pyexpr(self._expr // expr._expr) | ||
|
|
||
| def __rfloordiv__(self, other: object) -> Expression: |
There was a problem hiding this comment.
Is this used / tested anywhere?
There was a problem hiding this comment.
This follows the __truediv__ and __rtruediv__. Currently only used in UT.
|
Thanks @colin-ho for your reviews. Let me address your comments later. |
|
Thanks @colin-ho |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2418