Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Expose read_sql partition bound strategy and default to min-max #3246

Merged
merged 3 commits into from
Nov 13, 2024

fix error message

4fea9d7
Select commit
Loading
Failed to load commit list.
Merged

[CHORE] Expose read_sql partition bound strategy and default to min-max #3246

fix error message
4fea9d7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 7, 2024 in 1s

78.52% (-0.62%) compared to 2b71ffb

View this Pull Request on Codecov

78.52% (-0.62%) compared to 2b71ffb

Details

Codecov Report

Attention: Patch coverage is 16.66667% with 35 lines in your changes missing coverage. Please review.

Project coverage is 78.52%. Comparing base (2b71ffb) to head (4fea9d7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
daft/sql/sql_scan.py 14.63% 35 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3246      +/-   ##
==========================================
- Coverage   79.13%   78.52%   -0.62%     
==========================================
  Files         640      641       +1     
  Lines       77983    79095    +1112     
==========================================
+ Hits        61715    62107     +392     
- Misses      16268    16988     +720     
Files with missing lines Coverage Δ
daft/io/_sql.py 51.85% <100.00%> (ø)
daft/sql/sql_scan.py 25.54% <14.63%> (-0.02%) ⬇️

... and 34 files with indirect coverage changes