Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: bad merge from intersect PR #3273

Merged
merged 1 commit into from
Nov 12, 2024
Merged

[BUG]: bad merge from intersect PR #3273

merged 1 commit into from
Nov 12, 2024

Conversation

universalmind303
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the bug Something isn't working label Nov 12, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #3273 will degrade performances by 15.39%

Comparing universalmind303:intersect-fix (6091dcd) with main (e37c6d3)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main universalmind303:intersect-fix Change
❌ test_iter_rows_first_row[100 Small Files] 339.9 ms 401.7 ms -15.39%
⚡ test_show[100 Small Files] 40.6 ms 32.7 ms +24.07%

@universalmind303 universalmind303 enabled auto-merge (squash) November 12, 2024 23:34
@universalmind303 universalmind303 merged commit 62a936e into Eventual-Inc:main Nov 12, 2024
39 of 40 checks passed
@universalmind303 universalmind303 deleted the intersect-fix branch November 12, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinzwang kevinzwang kevinzwang approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@universalmind303 @kevinzwang