Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: allow is_in to take in Vec<Expr> instead of Expr #3294

Merged
merged 5 commits into from
Nov 15, 2024
Merged

[FEAT]: allow is_in to take in Vec<Expr> instead of Expr #3294

merged 5 commits into from
Nov 15, 2024

Conversation

universalmind303
Copy link
Contributor

closes #3140

@github-actions github-actions bot added the enhancement New feature or request label Nov 14, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 14, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3294 will improve performances by 32.68%

Comparing universalmind303:is-in-expr (d8d6d8a) with main (0709691)

Summary

⚡ 1 improvements
✅ 16 untouched benchmarks

Benchmarks breakdown

Benchmark main universalmind303:is-in-expr Change
⚡ test_iter_rows_first_row[100 Small Files] 317.6 ms 239.4 ms +32.68%

kevinzwang
kevinzwang approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I missed it, but do we want to do any checks to ensure that the cardinality of each series in the is_in ends up being 1?

src/daft-logical-plan/src/ops/project.rs Outdated Show resolved Hide resolved
@universalmind303 universalmind303 merged commit cf25ad4 into Eventual-Inc:main Nov 15, 2024
40 checks passed
@universalmind303 universalmind303 deleted the is-in-expr branch January 23, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinzwang kevinzwang kevinzwang approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@universalmind303 @kevinzwang