Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Cleanup ExprResolver #3401

Merged
merged 6 commits into from
Nov 25, 2024

Merge branch 'main' into kevin/groupby-key-in-agg

af8b536
Select commit
Loading
Failed to load commit list.
Merged

[CHORE] Cleanup ExprResolver #3401

Merge branch 'main' into kevin/groupby-key-in-agg
af8b536
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 22, 2024 in 0s

77.35% (-0.01%) compared to 68248a9

View this Pull Request on Codecov

77.35% (-0.01%) compared to 68248a9

Details

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.35%. Comparing base (68248a9) to head (af8b536).

Files with missing lines Patch % Lines
src/daft-dsl/src/resolve_expr/mod.rs 60.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3401      +/-   ##
==========================================
- Coverage   77.35%   77.35%   -0.01%     
==========================================
  Files         685      685              
  Lines       83644    83646       +2     
==========================================
- Hits        64705    64703       -2     
- Misses      18939    18943       +4     
Files with missing lines Coverage Δ
src/daft-logical-plan/src/ops/agg.rs 58.13% <100.00%> (-1.87%) ⬇️
src/daft-logical-plan/src/ops/pivot.rs 70.58% <100.00%> (-0.85%) ⬇️
src/daft-dsl/src/resolve_expr/mod.rs 88.88% <60.00%> (-1.33%) ⬇️

... and 4 files with indirect coverage changes

---- 🚨 Try these New Features: