-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] migrate schema inference → async, block at py boundary #3432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be39505
to
ec9e285
Compare
CodSpeed Performance ReportMerging #3432 will degrade performances by 42.44%Comparing Summary
Benchmarks breakdown
|
f71c980
to
1429f0f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3432 +/- ##
==========================================
+ Coverage 77.35% 77.36% +0.01%
==========================================
Files 684 684
Lines 83637 83692 +55
==========================================
+ Hits 64695 64751 +56
+ Misses 18942 18941 -1
|
colin-ho
reviewed
Nov 27, 2024
9806a0b
to
e65c236
Compare
colin-ho
approved these changes
Nov 27, 2024
e65c236
to
f23654a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts schema inference operations for CSV, JSON, and Parquet files to use async/await instead of synchronous runtime blocking. This architectural change ensures that blocking operations happen at the highest level possible (the Python API boundary) rather than deep within the inference logic. Key changes include:
This change improves the consistency of async IO handling and creates a cleaner architecture where blocking is consolidated at the Python interface rather than scattered throughout the codebase.