Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Explicitly set IO config in unity catalog load table #3453

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented Nov 29, 2024

Linters don't seem to catch unbound local variables if they are defined in multiple branches.

@github-actions github-actions bot added the bug Something isn't working label Nov 29, 2024
Copy link

codspeed-hq bot commented Nov 29, 2024

CodSpeed Performance Report

Merging #3453 will degrade performances by 16.4%

Comparing colin/bound-unity-ioconfig (be8ee0f) with main (c7f37e4)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main colin/bound-unity-ioconfig Change
test_count[1 Small File] 3.5 ms 4.2 ms -16.4%
test_iter_rows_first_row[100 Small Files] 406.1 ms 305.8 ms +32.8%
test_show[100 Small Files] 25.8 ms 17.2 ms +50%

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.49%. Comparing base (c7f37e4) to head (be8ee0f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
daft/unity_catalog/unity_catalog.py 20.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3453   +/-   ##
=======================================
  Coverage   77.49%   77.49%           
=======================================
  Files         687      687           
  Lines       84477    84483    +6     
=======================================
+ Hits        65464    65473    +9     
+ Misses      19013    19010    -3     
Files with missing lines Coverage Δ
daft/unity_catalog/unity_catalog.py 10.29% <20.00%> (+0.91%) ⬆️

... and 4 files with indirect coverage changes

@colin-ho colin-ho merged commit 573f76f into main Nov 29, 2024
42 of 44 checks passed
@colin-ho colin-ho deleted the colin/bound-unity-ioconfig branch November 29, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants