Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parquet): Target parquet writes by size bytes instead of rows #3457

Merged
merged 18 commits into from
Dec 6, 2024

update bytes written comment

a89724a
Select commit
Loading
Failed to load commit list.
Merged

feat(parquet): Target parquet writes by size bytes instead of rows #3457

update bytes written comment
a89724a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 6, 2024 in 1s

77.60% (+0.59%) compared to 6d30e30

View this Pull Request on Codecov

77.60% (+0.59%) compared to 6d30e30

Details

Codecov Report

Attention: Patch coverage is 89.21833% with 40 lines in your changes missing coverage. Please review.

Project coverage is 77.60%. Comparing base (6d30e30) to head (a89724a).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
daft/io/writer.py 0.00% 26 Missing ⚠️
src/daft-writers/src/partition.rs 50.00% 6 Missing ⚠️
src/daft-writers/src/file.rs 96.38% 3 Missing ⚠️
src/daft-writers/src/lance.rs 70.00% 3 Missing ⚠️
src/daft-writers/src/batch.rs 99.25% 1 Missing ⚠️
src/daft-writers/src/lib.rs 98.64% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3457      +/-   ##
==========================================
+ Coverage   77.00%   77.60%   +0.59%     
==========================================
  Files         696      706      +10     
  Lines       86039    86225     +186     
==========================================
+ Hits        66256    66916     +660     
+ Misses      19783    19309     -474     
Files with missing lines Coverage Δ
src/daft-local-execution/src/pipeline.rs 93.76% <100.00%> (-0.70%) ⬇️
src/daft-local-execution/src/sinks/write.rs 100.00% <100.00%> (ø)
src/daft-writers/src/pyarrow.rs 99.41% <100.00%> (+0.03%) ⬆️
src/daft-writers/src/test.rs 96.36% <100.00%> (+0.44%) ⬆️
src/daft-writers/src/batch.rs 99.10% <99.25%> (-0.11%) ⬇️
src/daft-writers/src/lib.rs 98.33% <98.64%> (+2.25%) ⬆️
src/daft-writers/src/file.rs 97.80% <96.38%> (-1.46%) ⬇️
src/daft-writers/src/lance.rs 95.16% <70.00%> (-4.84%) ⬇️
src/daft-writers/src/partition.rs 86.79% <50.00%> (-5.13%) ⬇️
daft/io/writer.py 0.00% <0.00%> (ø)

... and 99 files with indirect coverage changes