Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: dont panic on count(distinct) #3481

Merged

Conversation

universalmind303
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the bug Something isn't working label Dec 3, 2024
Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #3481 will improve performances by 32.9%

Comparing universalmind303:count-distinct-no-panic (b09ff61) with main (75ad85a)

Summary

⚡ 1 improvements
✅ 16 untouched benchmarks

Benchmarks breakdown

Benchmark main universalmind303:count-distinct-no-panic Change
test_show[100 Small Files] 34.3 ms 25.8 ms +32.9%

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.33%. Comparing base (75ad85a) to head (b09ff61).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-sql/src/modules/aggs.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3481      +/-   ##
==========================================
- Coverage   77.43%   77.33%   -0.11%     
==========================================
  Files         696      696              
  Lines       84497    84616     +119     
==========================================
+ Hits        65429    65435       +6     
- Misses      19068    19181     +113     
Files with missing lines Coverage Δ
src/daft-sql/src/modules/aggs.rs 72.83% <0.00%> (ø)

... and 6 files with indirect coverage changes

Copy link
Contributor

@raunakab raunakab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raunakab raunakab merged commit 751a915 into Eventual-Inc:main Dec 4, 2024
41 of 42 checks passed
@universalmind303 universalmind303 deleted the count-distinct-no-panic branch January 23, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants