Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(swordfish): Optimize grouped aggregations #3534

Merged
merged 20 commits into from
Dec 17, 2024

make agg determination method on state

af2bd8d
Select commit
Loading
Failed to load commit list.
Merged

feat(swordfish): Optimize grouped aggregations #3534

make agg determination method on state
af2bd8d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 17, 2024 in 0s

77.81% (+0.00%) compared to 35ed63c

View this Pull Request on Codecov

77.81% (+0.00%) compared to 35ed63c

Details

Codecov Report

Attention: Patch coverage is 89.91354% with 35 lines in your changes missing coverage. Please review.

Project coverage is 77.81%. Comparing base (35ed63c) to head (af2bd8d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...aft-local-execution/src/sinks/grouped_aggregate.rs 91.95% 23 Missing ⚠️
src/common/daft-config/src/python.rs 40.00% 9 Missing ⚠️
src/daft-local-execution/src/pipeline.rs 66.66% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #3534    +/-   ##
========================================
  Coverage   77.81%   77.81%            
========================================
  Files         716      716            
  Lines       87987    88241   +254     
========================================
+ Hits        68463    68667   +204     
- Misses      19524    19574    +50     
Files with missing lines Coverage Δ
daft/context.py 87.19% <ø> (ø)
src/common/daft-config/src/lib.rs 84.05% <100.00%> (+0.47%) ⬆️
src/daft-local-execution/src/lib.rs 95.29% <ø> (ø)
src/daft-local-execution/src/sinks/aggregate.rs 97.33% <100.00%> (+1.58%) ⬆️
src/daft-local-execution/src/pipeline.rs 88.69% <66.66%> (-1.89%) ⬇️
src/common/daft-config/src/python.rs 68.39% <40.00%> (-2.17%) ⬇️
...aft-local-execution/src/sinks/grouped_aggregate.rs 91.95% <91.95%> (ø)

... and 6 files with indirect coverage changes