Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Output results in a CSV format #3625

Merged
merged 16 commits into from
Dec 19, 2024
Merged

ci: Output results in a CSV format #3625

merged 16 commits into from
Dec 19, 2024

Conversation

raunakab
Copy link
Contributor

@raunakab raunakab commented Dec 19, 2024

Overview

This PR makes the visualizations of the run-cluster more user-friendly.

Usage

If you're ever running a script (on the GHA runner node, not on ray), you can output whatever files you want to the $GHA_OUTPUT_DIR env-variable, and that file or directory will be uploaded to the GitHub Actions Summary Page once the job fully completes.

This is what the .github/ci-scripts/job_runner.py file does. If you ever create a new GHA runner script, then outputting any files to the $GHA_OUTPUT_DIR will work.

@github-actions github-actions bot added the ci label Dec 19, 2024
Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #3625 will improve performances by 17.7%

Comparing csv-outputs (a43ade4) with main (07f6b2c)

Summary

⚡ 1 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark main csv-outputs Change
test_iter_rows_first_row[100 Small Files] 244 ms 207.3 ms +17.7%

@raunakab raunakab marked this pull request as ready for review December 19, 2024 21:26
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.84%. Comparing base (07f6b2c) to head (a43ade4).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3625   +/-   ##
=======================================
  Coverage   77.84%   77.84%           
=======================================
  Files         719      719           
  Lines       88280    88280           
=======================================
+ Hits        68720    68721    +1     
+ Misses      19560    19559    -1     

see 1 file with indirect coverage changes

@raunakab
Copy link
Contributor Author

raunakab commented Dec 19, 2024

@raunakab raunakab merged commit f6002f9 into main Dec 19, 2024
45 checks passed
@raunakab raunakab deleted the csv-outputs branch December 19, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants