Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Publish A Long Term Support CPU Release of Daft #3650

Merged
merged 11 commits into from
Jan 9, 2025
Merged

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Jan 7, 2025

closes: #3564

  • Create new daft release daft-lts that supports older cpus
  • upgrade regular daft to use more modern cpu features
  • move off using API token for PYPI to using identity based upload

@github-actions github-actions bot added the chore label Jan 7, 2025
Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #3650 will improve performances by 10.63%

Comparing sammy/lts-build (77f6635) with main (1562569)

Summary

⚡ 1 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark main sammy/lts-build Change
test_count[1 Small File] 3.7 ms 3.3 ms +10.63%

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.02%. Comparing base (e2d4c86) to head (77f6635).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3650      +/-   ##
==========================================
- Coverage   78.05%   78.02%   -0.03%     
==========================================
  Files         725      727       +2     
  Lines       89217    89633     +416     
==========================================
+ Hits        69634    69937     +303     
- Misses      19583    19696     +113     

see 40 files with indirect coverage changes

@samster25 samster25 changed the title chore: wip build to try build: Publish A Long Term Support CPU Release of Daft Jan 8, 2025
@github-actions github-actions bot added build and removed chore labels Jan 8, 2025
@samster25 samster25 marked this pull request as ready for review January 8, 2025 21:24
Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samster25 samster25 merged commit e0a2f69 into main Jan 9, 2025
54 checks passed
@samster25 samster25 deleted the sammy/lts-build branch January 9, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daft equivalent of polars-lts-cpu
2 participants