chore(connect): better error propagation & handling #3675
Conversation
CodSpeed Performance ReportMerging #3675 will improve performances by 31.1%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3675 +/- ##
==========================================
+ Coverage 76.75% 76.81% +0.06%
==========================================
Files 728 729 +1
Lines 90944 91164 +220
==========================================
+ Hits 69803 70027 +224
+ Misses 21141 21137 -4
|
| } | ||
| plan => bail!("Unsupported relation type: \"{}\"", rel_name(&plan)), | ||
| plan => not_yet_implemented!("relation type: \"{}\"", rel_name(&plan))?, |
There was a problem hiding this comment.
Minor nit:
Change to not_yet_implemented!(r#"relation type: "{}""#, rel_name(&plan))?, which will allow you to avoid escaping nested quotes.
| let name = table.table_name; | ||
| bail!("Tried to write to table {name} but it is not yet implemented. Try to write to a path instead."); | ||
| SaveType::Table(_) => { | ||
| return not_yet_implemented!("write to table").map_err(|e| e.into()) |
There was a problem hiding this comment.
Should we have not_yet_implemented act similar to bail? I.e., the macro expands to a return Err(..)?;?
There was a problem hiding this comment.
so I think I'll follow up with this in a separate PR. I'm planning on removing the eyre crate, and make the error handling similar to the rest of the codebase.
depends on #3666
see here for proper diff
universalmind303/Daft@rust-ray-exec...universalmind303:Daft:error-messages