Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set filter selectivity estimate lower bound #3694

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented Jan 16, 2025

Set filter selectivity estimate lower bound to 1%, to prevent overly selective and likely inaccurate estimations.

@github-actions github-actions bot added the fix label Jan 16, 2025
Copy link

codspeed-hq bot commented Jan 16, 2025

CodSpeed Performance Report

Merging #3694 will improve performances by 10.71%

Comparing colin/selectivity-lower-bound (672396e) with main (4b67e5a)

Summary

⚡ 1 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark main colin/selectivity-lower-bound Change
test_count[1 Small File] 3.7 ms 3.4 ms +10.71%

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.85%. Comparing base (4b67e5a) to head (672396e).
Report is 30 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3694   +/-   ##
=======================================
  Coverage   77.84%   77.85%           
=======================================
  Files         732      732           
  Lines       90605    90608    +3     
=======================================
+ Hits        70534    70541    +7     
+ Misses      20071    20067    -4     
Files with missing lines Coverage Δ
src/daft-dsl/src/expr/mod.rs 76.00% <100.00%> (+0.02%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@desmondcheongzx desmondcheongzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@desmondcheongzx desmondcheongzx merged commit 6a762d7 into main Jan 30, 2025
45 checks passed
@desmondcheongzx desmondcheongzx deleted the colin/selectivity-lower-bound branch January 30, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants