Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: send slack notification for broken links #3742

Merged
merged 5 commits into from
Feb 4, 2025
Merged

Conversation

ccmao1130
Copy link
Contributor

Seems like Slack notifications stopped working after #3317

Seems like Slack notifications stopped working after #3317
@ccmao1130 ccmao1130 requested a review from samster25 January 30, 2025 23:11
@github-actions github-actions bot added the ci label Jan 30, 2025
Copy link

codspeed-hq bot commented Jan 30, 2025

CodSpeed Performance Report

Merging #3742 will degrade performances by 42.04%

Comparing slack-broken-link (88c6f0a) with main (d53e64b)

Summary

❌ 1 regressions
✅ 26 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_iter_rows_first_row[100 Small Files] 175 ms 301.9 ms -42.04%

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.78%. Comparing base (3462732) to head (88c6f0a).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3742      +/-   ##
==========================================
+ Coverage   77.65%   77.78%   +0.13%     
==========================================
  Files         731      733       +2     
  Lines       92379    92662     +283     
==========================================
+ Hits        71734    72075     +341     
+ Misses      20645    20587      -58     

see 30 files with indirect coverage changes

@ccmao1130 ccmao1130 requested review from desmondcheongzx and removed request for samster25 February 4, 2025 02:58
@ccmao1130 ccmao1130 enabled auto-merge (squash) February 4, 2025 05:18
@ccmao1130 ccmao1130 merged commit 62d6b97 into main Feb 4, 2025
40 of 42 checks passed
@ccmao1130 ccmao1130 deleted the slack-broken-link branch February 4, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants