Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix universal expressions on temporals #895

Merged
merged 4 commits into from
May 5, 2023
Merged

Fix universal expressions on temporals #895

merged 4 commits into from
May 5, 2023

Conversation

xcharleslin
Copy link
Contributor

@xcharleslin xcharleslin commented May 5, 2023 •
edited
Loading

Expressions like (datecol + datecol) were not working, mostly because universal expressions for Python types were not allowed at the expressions level, so that has been fixed.

Also:

  • Added names to series construction calls when available; without this, there were series name mismatch errors
  • py_binary_op didn't implement broadcast (and would silently produce undefined behaviour if the lengths mismatched); added broadcast to py_binary_op with a panic
  • Added simple tests for universal temporal ops

@xcharleslin xcharleslin marked this pull request as ready for review May 5, 2023 18:30
@xcharleslin xcharleslin enabled auto-merge (squash) May 5, 2023 18:30
@xcharleslin xcharleslin merged commit 4ff216f into main May 5, 2023
@xcharleslin xcharleslin deleted the charles/fix-dateops branch May 5, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xcharleslin